hts221: Add data ready polling in _ensure_data().#130
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the HTS221 driver’s one-shot auto-trigger path to wait for a data-ready indication instead of relying solely on a fixed delay, aligning HTS221 with the broader “poll + timeout” pattern used in other drivers.
Changes:
- Add bounded polling of
HTS221_STATUS_REGaftertrigger_one_shot()in_ensure_data(). - Raise
OSErroron data-ready timeout to avoid silent hangs/infinite waits.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🎉 This PR is included in version 0.0.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #127
Summary
Add polling of
STATUS_T_DAbit aftertrigger_one_shot()withOSErroron timeout, consistent with WSEN-HIDS, LIS2MDL, VL53L1X, APDS9960, and ISM330DL.Test plan